Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
A
atlas
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
dataplatform
atlas
Commits
19abdf68
Commit
19abdf68
authored
7 years ago
by
kevalbhatt
Committed by
Madhan Neethiraj
7 years ago
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ATLAS-2539: UI fix to handle page loader in entity-details page when no lineage data is present
Signed-off-by:
Madhan Neethiraj
<
madhan@apache.org
>
parent
3709842a
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
19 additions
and
4 deletions
+19
-4
DetailPageLayoutView.js
...ardv2/public/js/views/detail_page/DetailPageLayoutView.js
+19
-4
No files found.
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js
View file @
19abdf68
...
...
@@ -228,6 +228,14 @@ define(['require',
this
.
renderSchemaLayoutView
(
_
.
extend
({},
obj
,
{
attribute
:
collectionJSON
.
attributes
[
schemaOptions
.
schemaElementsAttribute
]
}));
}
else
if
(
this
.
value
&&
this
.
value
.
tabActive
==
"schema"
)
{
Utils
.
setUrl
({
url
:
Utils
.
getUrlState
.
getQueryUrl
().
queyParams
[
0
],
urlParams
:
{
tabActive
:
'properties'
},
mergeBrowserUrl
:
false
,
trigger
:
true
,
updateTabState
:
true
});
}
if
(
this
.
activeEntityDef
&&
_
.
contains
(
this
.
activeEntityDef
.
get
(
'superTypes'
),
"DataSet"
))
{
this
.
$
(
'.lineageGraph'
).
show
();
...
...
@@ -245,6 +253,14 @@ define(['require',
ui
.
element
.
height
((
$
(
this
).
height
()));
},
});
}
else
if
(
this
.
value
&&
this
.
value
.
tabActive
==
"lineage"
)
{
Utils
.
setUrl
({
url
:
Utils
.
getUrlState
.
getQueryUrl
().
queyParams
[
0
],
urlParams
:
{
tabActive
:
'properties'
},
mergeBrowserUrl
:
false
,
trigger
:
true
,
updateTabState
:
true
});
}
},
this
);
this
.
listenTo
(
this
.
collection
,
'error'
,
function
(
model
,
response
)
{
...
...
@@ -285,10 +301,9 @@ define(['require',
// })
},
onShow
:
function
()
{
var
params
=
Utils
.
getUrlState
.
getQueryParams
();
if
(
params
&&
params
.
tabActive
)
{
this
.
$
(
'.nav.nav-tabs'
).
find
(
'[role="'
+
params
.
tabActive
+
'"]'
).
addClass
(
'active'
).
siblings
().
removeClass
(
'active'
);
this
.
$
(
'.tab-content'
).
find
(
'[role="'
+
params
.
tabActive
+
'"]'
).
addClass
(
'active'
).
siblings
().
removeClass
(
'active'
);
if
(
this
.
value
&&
this
.
value
.
tabActive
)
{
this
.
$
(
'.nav.nav-tabs'
).
find
(
'[role="'
+
this
.
value
.
tabActive
+
'"]'
).
addClass
(
'active'
).
siblings
().
removeClass
(
'active'
);
this
.
$
(
'.tab-content'
).
find
(
'[role="'
+
this
.
value
.
tabActive
+
'"]'
).
addClass
(
'active'
).
siblings
().
removeClass
(
'active'
);
$
(
"html, body"
).
animate
({
scrollTop
:
(
this
.
$
(
'.tab-content'
).
offset
().
top
+
1200
)
},
1000
);
}
},
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment