Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
A
atlas
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
dataplatform
atlas
Commits
4e4038f6
Commit
4e4038f6
authored
6 years ago
by
kevalbhatt
Committed by
Sarath Subramanian
6 years ago
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ATLAS-3218 : UI - entity detail page columns sorting empty value check
Signed-off-by:
Sarath Subramanian
<
ssubramanian@cloudera.com
>
parent
732b730c
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
38 additions
and
5 deletions
+38
-5
CommonViewFunction.js
dashboardv2/public/js/utils/CommonViewFunction.js
+4
-4
Utils.js
dashboardv2/public/js/utils/Utils.js
+28
-0
DetailPageLayoutView.js
...ardv2/public/js/views/detail_page/DetailPageLayoutView.js
+6
-1
No files found.
dashboardv2/public/js/utils/CommonViewFunction.js
View file @
4e4038f6
...
...
@@ -104,7 +104,7 @@ define(['require', 'utils/Utils', 'modules/Modal', 'utils/Messages', 'utils/Enum
value
=
Utils
.
getName
(
data
);
var
id
=
""
;
if
(
data
.
guid
)
{
if
(
Enums
.
entityStateReadOnly
[
data
.
status
])
{
if
(
Enums
.
entityStateReadOnly
[
data
.
status
||
data
.
entityStatus
])
{
deleteButton
+=
'<button title="Deleted" class="btn btn-action btn-md deleteBtn"><i class="fa fa-trash"></i></button>'
;
}
id
=
data
.
guid
;
...
...
@@ -144,7 +144,7 @@ define(['require', 'utils/Utils', 'modules/Modal', 'utils/Messages', 'utils/Enum
var
inputOutputField
=
keyValue
[
i
],
id
=
inputOutputField
.
guid
||
(
_
.
isObject
(
inputOutputField
.
id
)
?
inputOutputField
.
id
.
id
:
inputOutputField
.
id
),
tempLink
=
""
,
status
=
inputOutputField
.
status
||
(
_
.
isObject
(
inputOutputField
.
id
)
?
inputOutputField
.
id
.
state
:
inputOutputField
.
state
),
status
=
(
inputOutputField
.
status
||
inputOutputField
.
entityStatus
)
||
(
_
.
isObject
(
inputOutputField
.
id
)
?
inputOutputField
.
id
.
state
:
inputOutputField
.
state
),
readOnly
=
Enums
.
entityStateReadOnly
[
status
];
if
(
!
inputOutputField
.
attributes
&&
inputOutputField
.
values
)
{
inputOutputField
[
'attributes'
]
=
inputOutputField
.
values
;
...
...
@@ -303,7 +303,7 @@ define(['require', 'utils/Utils', 'modules/Modal', 'utils/Messages', 'utils/Enum
++
count
;
});
}
if
(
!
Enums
.
entityStateReadOnly
[
obj
.
status
])
{
if
(
!
Enums
.
entityStateReadOnly
[
obj
.
status
||
obj
.
entityStatus
])
{
if
(
obj
.
guid
)
{
addTag
+=
'<a href="javascript:void(0)" data-id="addTag" class="btn btn-action btn-sm assignTag" data-guid="'
+
obj
.
guid
+
'" ><i class="fa fa-plus"></i></a>'
;
}
else
{
...
...
@@ -335,7 +335,7 @@ define(['require', 'utils/Utils', 'modules/Modal', 'utils/Messages', 'utils/Enum
++
count
;
});
}
if
(
!
Enums
.
entityStateReadOnly
[
obj
.
status
])
{
if
(
!
Enums
.
entityStateReadOnly
[
obj
.
status
||
obj
.
entityStatus
])
{
if
(
obj
.
guid
)
{
addTerm
+=
'<a href="javascript:void(0)" data-id="addTerm" class="btn btn-action btn-sm assignTag" data-guid="'
+
obj
.
guid
+
'" ><i class="fa fa-plus"></i></a>'
;
}
else
{
...
...
This diff is collapsed.
Click to expand it.
dashboardv2/public/js/utils/Utils.js
View file @
4e4038f6
...
...
@@ -579,6 +579,34 @@ define(['require', 'utils/Globals', 'pnotify', 'utils/Messages', 'utils/Enums',
});
}
}
Utils
.
findAndMergeRelationShipEntity
=
function
(
options
)
{
var
attributeObject
=
options
.
attributeObject
,
relationshipAttributes
=
options
.
relationshipAttributes
;
_
.
each
(
attributeObject
,
function
(
val
,
key
)
{
var
attributVal
=
val
;
if
(
relationshipAttributes
&&
relationshipAttributes
[
key
])
{
var
relationShipVal
=
relationshipAttributes
[
key
];
if
(
_
.
isObject
(
val
))
{
if
(
_
.
isArray
(
val
))
{
_
.
each
(
val
,
function
(
attr
)
{
if
(
attr
&&
attr
.
attributes
===
undefined
)
{
var
entityFound
=
_
.
find
(
relationShipVal
,
{
guid
:
attr
.
guid
});
if
(
entityFound
)
{
attr
.
attributes
=
_
.
omit
(
entityFound
,
'typeName'
,
'guid'
,
'entityStatus'
);
attr
.
status
=
entityFound
.
entityStatus
;
}
}
});
}
else
if
(
relationShipVal
&&
val
.
attributes
===
undefined
)
{
val
.
attributes
=
_
.
omit
(
relationShipVal
,
'typeName'
,
'guid'
,
'entityStatus'
);
val
.
status
=
relationShipVal
.
entityStatus
;
}
}
}
})
}
Utils
.
getNestedSuperTypes
=
function
(
options
)
{
var
data
=
options
.
data
,
collection
=
options
.
collection
,
...
...
This diff is collapsed.
Click to expand it.
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js
View file @
4e4038f6
...
...
@@ -141,6 +141,11 @@ define(['require',
referredEntities
:
this
.
entityObject
.
referredEntities
});
Utils
.
findAndMergeRelationShipEntity
({
attributeObject
:
collectionJSON
.
attributes
,
relationshipAttributes
:
collectionJSON
.
relationshipAttributes
});
// check if entity is process
var
isProcess
=
false
,
superTypes
=
Utils
.
getNestedSuperTypes
({
data
:
this
.
activeEntityDef
.
toJSON
(),
collection
:
this
.
entityDefCollection
}),
...
...
@@ -217,7 +222,7 @@ define(['require',
}
if
(
collectionJSON
.
attributes
&&
collectionJSON
.
attributes
.
columns
)
{
var
valueSorted
=
_
.
sortBy
(
collectionJSON
.
attributes
.
columns
,
function
(
val
)
{
return
val
.
attributes
.
position
return
val
.
attributes
&&
val
.
attributes
.
position
});
collectionJSON
.
attributes
.
columns
=
valueSorted
;
}
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment