ATLAS-2957: Fix and enable disabled StormHook Integrations Tests

addons/storm-bridge/src/test/java/org/apache/atlas/storm/hook/StormAtlasHookIT.java

@@ -36,7 +36,7 @@ import org.testng.annotations.AfterClass;
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 
-@Test(enabled = false)
+@Test
 public class StormAtlasHookIT {
 
     public static final Logger LOG = LoggerFactory.getLogger(StormAtlasHookIT.class);
@@ -70,8 +70,7 @@ public class StormAtlasHookIT {
         atlasClient = null;
     }
 
-    //TODO: Fix failing test
-    @Test(enabled = false)
+    @Test
     public void testAddEntities() throws Exception {
         StormTopology stormTopology = StormTestUtil.createTestTopology();
         StormTestUtil.submitTopology(stormCluster, TOPOLOGY_NAME, stormTopology);

notification/src/main/java/org/apache/atlas/hook/FailedMessagesLogger.java

@@ -73,17 +73,19 @@ public class FailedMessagesLogger {
      * @return directory under which host component's logs are stored.
      */
     private String getRootLoggerDirectory() {
-        String rootLoggerDirectory = null;
-        org.apache.log4j.Logger rootLogger = org.apache.log4j.Logger.getRootLogger();
+        String      rootLoggerDirectory = null;
+        Logger      rootLogger          = Logger.getRootLogger();
+        Enumeration allAppenders        = rootLogger.getAllAppenders();
 
-        Enumeration allAppenders = rootLogger.getAllAppenders();
         if (allAppenders != null) {
             while (allAppenders.hasMoreElements()) {
                 Appender appender = (Appender) allAppenders.nextElement();
+
                 if (appender instanceof FileAppender) {
-                    FileAppender fileAppender = (FileAppender) appender;
-                    String rootLoggerFile = fileAppender.getFile();
-                    rootLoggerDirectory = new File(rootLoggerFile).getParent();
+                    FileAppender fileAppender   = (FileAppender) appender;
+                    String       rootLoggerFile = fileAppender.getFile();
+
+                    rootLoggerDirectory = rootLoggerFile != null ? new File(rootLoggerFile).getParent() : null;
                     break;
                 }
             }

pom.xml

@@ -1902,6 +1902,8 @@
                     <systemProperties>
                         <user.dir>${project.basedir}</user.dir>
                         <atlas.data>${project.build.directory}/data</atlas.data>
+                        <atlas.log.dir>${project.build.directory}/logs</atlas.log.dir>
+                        <atlas.log.file>application.log</atlas.log.file>
                         <log4j.configuration>atlas-log4j.xml</log4j.configuration>
                         <embedded.solr.directory>${project.basedir}/target</embedded.solr.directory>
                     </systemProperties>
@@ -1932,6 +1934,8 @@
                     <systemPropertyVariables>
                         <projectBaseDir>${projectBaseDir}</projectBaseDir>
                         <atlas.data>${project.build.directory}/data</atlas.data>
+                        <atlas.log.dir>${project.build.directory}/logs</atlas.log.dir>
+                        <atlas.log.file>application.log</atlas.log.file>
                         <log4j.configuration>atlas-log4j.xml</log4j.configuration>
                         <embedded.solr.directory>${project.basedir}/target</embedded.solr.directory>
                     </systemPropertyVariables>