ATLAS-2505: add client IP address in authorization requests

authorization/pom.xml

@@ -41,6 +41,11 @@
       </dependency>
 
       <dependency>
+          <groupId>org.apache.atlas</groupId>
+          <artifactId>atlas-server-api</artifactId>
+      </dependency>
+
+      <dependency>
           <groupId>javax.servlet</groupId>
           <artifactId>javax.servlet-api</artifactId>
           <version>${javax.servlet.version}</version>

authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java

@@ -33,7 +33,7 @@ import java.net.InetAddress;
 import java.net.UnknownHostException;
 import java.util.HashSet;
 import java.util.Set;
-
+import org.apache.atlas.RequestContextV1;
 
 public class AtlasAuthorizationUtils {
     private static final Logger LOG = LoggerFactory.getLogger(AtlasAuthorizationUtils.class);
@@ -71,7 +71,7 @@ public class AtlasAuthorizationUtils {
                 AtlasAuthorizer authorizer = AtlasAuthorizerFactory.getAtlasAuthorizer();
 
                 request.setUser(userName, getCurrentUserGroups());
-
+                request.setClientIPAddress(RequestContextV1.get().getClientIPAddress());
                 ret = authorizer.isAccessAllowed(request);
             } catch (AtlasAuthorizationException e) {
                 LOG.error("Unable to obtain AtlasAuthorizer", e);
@@ -92,7 +92,7 @@ public class AtlasAuthorizationUtils {
                 AtlasAuthorizer authorizer = AtlasAuthorizerFactory.getAtlasAuthorizer();
 
                 request.setUser(getCurrentUserName(), getCurrentUserGroups());
-
+                request.setClientIPAddress(RequestContextV1.get().getClientIPAddress());
                 ret = authorizer.isAccessAllowed(request);
             } catch (AtlasAuthorizationException e) {
                 LOG.error("Unable to obtain AtlasAuthorizer", e);
@@ -113,7 +113,7 @@ public class AtlasAuthorizationUtils {
                 AtlasAuthorizer authorizer = AtlasAuthorizerFactory.getAtlasAuthorizer();
 
                 request.setUser(getCurrentUserName(), getCurrentUserGroups());
-
+                request.setClientIPAddress(RequestContextV1.get().getClientIPAddress());
                 ret = authorizer.isAccessAllowed(request);
             } catch (AtlasAuthorizationException e) {
                 LOG.error("Unable to obtain AtlasAuthorizer", e);

server-api/src/main/java/org/apache/atlas/RequestContextV1.java

@@ -37,6 +37,8 @@ public class RequestContextV1 {
 
     private String      user;
     private Set<String> userGroups;
+    private String clientIPAddress;
+
 
     private RequestContextV1() {
     }
@@ -79,6 +81,14 @@ public class RequestContextV1 {
         this.userGroups = userGroups;
     }
 
+    public String getClientIPAddress() {
+        return clientIPAddress;
+    }
+
+    public void setClientIPAddress(String clientIPAddress) {
+        this.clientIPAddress = clientIPAddress;
+    }
+
     public void recordEntityUpdate(AtlasObjectId entity) {
         if (entity != null && entity.getGuid() != null) {
             updatedEntities.put(entity.getGuid(), entity);

webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java

@@ -76,7 +76,7 @@ public class AuditFilter implements Filter {
             RequestContextV1.clear();
             RequestContextV1 requestContext = RequestContextV1.get();
             requestContext.setUser(user, userGroups);
-
+            requestContext.setClientIPAddress(AtlasAuthorizationUtils.getRequestIpAddress(httpRequest));
             filterChain.doFilter(request, response);
         } finally {
             long timeTaken = System.currentTimeMillis() - startTime;