Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
A
atlas
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
dataplatform
atlas
Commits
5b9348f9
Commit
5b9348f9
authored
6 years ago
by
Abhishek Kadam
Committed by
Sarath Subramanian
6 years ago
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ATLAS-2819: UI: Re-evaluate classification propagation during entity delete #2
Signed-off-by:
Sarath Subramanian
<
ssubramanian@hortonworks.com
>
parent
02ec8b99
master
No related merge requests found
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
2 deletions
+10
-2
CommonViewFunction.js
dashboardv2/public/js/utils/CommonViewFunction.js
+2
-0
DetailPageLayoutView.js
...ardv2/public/js/views/detail_page/DetailPageLayoutView.js
+6
-2
SearchResultLayoutView.js
dashboardv2/public/js/views/search/SearchResultLayoutView.js
+2
-0
No files found.
dashboardv2/public/js/utils/CommonViewFunction.js
View file @
5b9348f9
...
...
@@ -253,6 +253,8 @@ define(['require', 'utils/Utils', 'modules/Modal', 'utils/Messages', 'utils/Enum
deleteIcon
=
""
;
if
(
obj
.
guid
===
tag
.
entityGuid
)
{
deleteIcon
=
'<i class="fa fa-times" data-id="delete" data-assetname="'
+
entityName
+
'"data-name="'
+
tag
.
typeName
+
'" data-type="tag" data-guid="'
+
obj
.
guid
+
'" ></i>'
;
}
else
if
(
obj
.
guid
!==
tag
.
entityGuid
&&
tag
.
entityStatus
===
"DELETED"
)
{
deleteIcon
=
'<i class="fa fa-times" data-id="delete" data-assetname="'
+
entityName
+
'"data-name="'
+
tag
.
typeName
+
'" data-type="tag" data-entityguid="'
+
tag
.
entityGuid
+
'" data-guid="'
+
obj
.
guid
+
'" ></i>'
;
}
else
{
className
+=
" propagte-classification"
;
}
...
...
This diff is collapsed.
Click to expand it.
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js
View file @
5b9348f9
...
...
@@ -320,8 +320,11 @@ define(['require',
},
onClickTagCross
:
function
(
e
)
{
var
that
=
this
,
tagName
=
$
(
e
.
currentTarget
).
parent
().
text
();
tagName
=
$
(
e
.
currentTarget
).
parent
().
text
(),
entityGuid
=
$
(
e
.
currentTarget
).
data
(
"entityguid"
);
CommonViewFunction
.
deleteTag
(
_
.
extend
({},
{
guid
:
that
.
id
,
associatedGuid
:
that
.
id
!=
entityGuid
?
entityGuid
:
null
,
msg
:
"<div class='ellipsis'>Remove: "
+
"<b>"
+
_
.
escape
(
tagName
)
+
"</b> assignment from"
+
" "
+
"<b>"
+
this
.
name
+
"?</b></div>"
,
titleMessage
:
Messages
.
removeTag
,
okText
:
"Remove"
,
...
...
@@ -373,7 +376,8 @@ define(['require',
tagData
+=
'<span class="btn btn-action btn-sm btn-icon btn-blue" title='
+
val
.
typeName
+
' data-id="tagClick"><span>'
+
val
.
typeName
+
'</span><i class="fa fa-close" data-id="deleteTag" data-type="tag" title="Remove Tag"></i></span>'
;
});
_
.
each
(
tag
.
propagated
,
function
(
val
)
{
propagatedTagListData
+=
'<span class="btn btn-action btn-sm btn-icon btn-blue" title='
+
val
.
typeName
+
' data-id="tagClick"><span>'
+
val
.
typeName
+
'</span></span>'
;
var
crossButton
=
'<i class="fa fa-close" data-id="deleteTag" data-entityguid="'
+
val
.
entityGuid
+
'" data-type="tag" title="Remove Tag"></i>'
;
propagatedTagListData
+=
'<span class="btn btn-action btn-sm btn-icon btn-blue" title='
+
val
.
typeName
+
' data-id="tagClick"><span>'
+
val
.
typeName
+
'</span>'
+
((
that
.
id
!==
val
.
entityGuid
&&
val
.
entityStatus
===
"DELETED"
)
?
crossButton
:
""
)
+
'</span>'
;
});
propagatedTagListData
!==
""
?
this
.
ui
.
propagatedTagDiv
.
show
()
:
this
.
ui
.
propagatedTagDiv
.
hide
();
this
.
ui
.
tagList
.
find
(
"span.btn"
).
remove
();
...
...
This diff is collapsed.
Click to expand it.
dashboardv2/public/js/views/search/SearchResultLayoutView.js
View file @
5b9348f9
...
...
@@ -954,10 +954,12 @@ define(['require',
var
that
=
this
,
tagName
=
$
(
e
.
target
).
data
(
"name"
),
guid
=
$
(
e
.
target
).
data
(
"guid"
),
entityGuid
=
$
(
e
.
target
).
data
(
"entityguid"
),
assetName
=
$
(
e
.
target
).
data
(
"assetname"
);
CommonViewFunction
.
deleteTag
({
tagName
:
tagName
,
guid
:
guid
,
associatedGuid
:
guid
!=
entityGuid
?
entityGuid
:
null
,
msg
:
"<div class='ellipsis'>Remove: "
+
"<b>"
+
_
.
escape
(
tagName
)
+
"</b> assignment from"
+
" "
+
"<b>"
+
assetName
+
" ?</b></div>"
,
titleMessage
:
Messages
.
removeTag
,
okText
:
"Remove"
,
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment