ATLAS-345 UI: Should allow tag addition on any search result that returns a…

dashboard/public/modules/search/searchController.js

@@ -133,7 +133,8 @@ angular.module('dgc.search').controller('SearchController', ['$scope', '$locatio
                 angular.forEach($scope.resultRows, function(value) {
                     var objVal = {},
                         curVal = value,
-                        onlyId = false;
+                        onlyId = false,
+                        traits = false;
 
                     if (curVal.name) {
                         objVal.name = curVal.name;
@@ -144,10 +145,7 @@ angular.module('dgc.search').controller('SearchController', ['$scope', '$locatio
                             if (ky === '$id$') {
                                 objVal.id = curVal[ky].id;
                                 onlyId = true;
-                            } else if (ky === '$traits$') {
-                                objVal[ky] = vl;
-                                objVal.Tools = objVal.id;
-                                onlyId = false;
+                                traits = true;
                             } else if (ky.indexOf('$') === -1) {
                                 objVal[ky] = vl;
                                 onlyId = false;
@@ -155,6 +153,11 @@ angular.module('dgc.search').controller('SearchController', ['$scope', '$locatio
                         }
                     });
 
+                    if (traits) {
+                        objVal.$traits$ = curVal.$traits$ || {};
+                        objVal.Tools = objVal.id;
+                    }
+
                     if (onlyId) {
                         objVal.guid = objVal.id;
                     }

dashboard/public/modules/search/views/search.html

@@ -68,7 +68,7 @@
                         </span>
                      </td>
                      <td>
-                        <div id="{{result['$id$'].id}}" ng-show="!dataTransitioned" class="wordBreak"><a class="tabsearchanchor" ng-repeat="(key, value) in result['$traits$']" data-ui-sref="search({query: key})" title="{{key}}">{{key}}<span> </span></a></div>
+                        <div id="{{result['$id$'].id || result.guid}}" ng-show="!dataTransitioned" class="wordBreak"><a class="tabsearchanchor" ng-repeat="(key, value) in result['$traits$']" data-ui-sref="search({query: key})" title="{{key}}">{{key}}<span> </span></a></div>
                      </td>
                      <td class="addTag"><img ng-src="img/addTag.png" tooltip="Add Tag" ng-click="openAddTagHome(result['$id$'].id || result.guid)"></td>
                   </tr>

release-log.txt

@@ -2,13 +2,19 @@ Apache Atlas Release Notes
 ==========================
 
 --trunk - unreleased
+INCOMPATIBLE CHANGES:
+
+ALL CHANGES:
+
 
+--Release 0.6-incubating
 INCOMPATIBLE CHANGES:
 ATLAS-58 Make hive hook reliable (shwethags)
 ATLAS-54 Rename configs in hive hook (shwethags)
 ATLAS-3 Mixed Index creation fails with Date types (sumasai via shwethags)
 
 ALL CHANGES:
+ATLAS-345 UI: Should allow tag addition on any search result that returns a reference-able entity (darshankumar89 via shwethags)
 ATLAS-279 UI not displaying results for certain successful "select" search queries (anilsg via shwethags)
 ATLAS-242 The qualified name for hive entities should be backward compatible (shwethags)
 ATLAS-361 Add validation when index backends are switched in ATLAS configuration (sumasai via shwethags)