Skip to content

A
atlas
Commit 7b14cfac by Ashutosh Mestry
Options

ATLAS-2589: HA typestore and graph indexer fix.

Signed-off-by: 's avatarAshutosh Mestry <amestry@hortonworks.com>
parent c76afbe2
Showing with 110 additions and 68 deletions
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java
...@@ -87,12 +87,13 @@ public final class AtlasGraphSONReader { ...@@ -87,12 +87,13 @@ public final class AtlasGraphSONReader {
switch (fieldName) { switch (fieldName) {
case GraphSONTokensTP2.MODE: case GraphSONTokensTP2.MODE:
parser.nextToken(); parser.nextToken();
final String mode = parser.getText(); final String mode = parser.getText();
if (!mode.equals("EXTENDED")) { if (!mode.equals("EXTENDED")) {
throw new IllegalStateException("The legacy GraphSON must be generated with GraphSONMode.EXTENDED"); throw new IllegalStateException("The legacy GraphSON must be generated with GraphSONMode.EXTENDED");
} }
counter.getAndIncrement();
break; break;
case GraphSONTokensTP2.VERTICES: case GraphSONTokensTP2.VERTICES:
...@@ -136,10 +137,15 @@ public final class AtlasGraphSONReader { ...@@ -136,10 +137,15 @@ public final class AtlasGraphSONReader {
} }
private void processElement(JsonParser parser, ParseElement parseElement, long startIndex) throws InterruptedException { private void processElement(JsonParser parser, ParseElement parseElement, long startIndex) throws InterruptedException {
LOG.info("processElement: {}: Starting... : counter at: {}", parseElement.getMessage(), counter.get());
try { try {
readerStatusManager.update(graph, counter.get(), true);
parseElement.setContext(graphSONUtility); parseElement.setContext(graphSONUtility);
WorkItemManager wim = JsonNodeProcessManager.create(graph, bulkLoadGraph, parseElement, numWorkers, batchSize, startIndex); WorkItemManager wim = JsonNodeProcessManager.create(graph, bulkLoadGraph, parseElement,
numWorkers, batchSize, shouldSkip(startIndex, counter.get()));
parser.nextToken(); parser.nextToken();
...@@ -165,12 +171,12 @@ public final class AtlasGraphSONReader { ...@@ -165,12 +171,12 @@ public final class AtlasGraphSONReader {
} finally { } finally {
LOG.info("processElement: {}: Done! : [{}]", parseElement.getMessage(), counter); LOG.info("processElement: {}: Done! : [{}]", parseElement.getMessage(), counter);
readerStatusManager.update(bulkLoadGraph, counter.get()); readerStatusManager.update(bulkLoadGraph, counter.get(), true);
} }
} }
private void postProcess(long startIndex) { private void postProcess(long startIndex) {
LOG.info("postProcess: Starting..."); LOG.info("postProcess: Starting... : counter at: {}", counter.get());
try { try {
PostProcessManager.WorkItemsManager wim = PostProcessManager.create(bulkLoadGraph, graphSONUtility, PostProcessManager.WorkItemsManager wim = PostProcessManager.create(bulkLoadGraph, graphSONUtility,
...@@ -186,9 +192,9 @@ public final class AtlasGraphSONReader { ...@@ -186,9 +192,9 @@ public final class AtlasGraphSONReader {
Vertex v = (Vertex) query.next(); Vertex v = (Vertex) query.next();
updateStatusConditionally(bulkLoadGraph, counter.get());
wim.produce(v.id()); wim.produce(v.id());
updateStatusConditionally(bulkLoadGraph, counter.get());
} }
wim.shutdown(); wim.shutdown();
...@@ -197,7 +203,7 @@ public final class AtlasGraphSONReader { ...@@ -197,7 +203,7 @@ public final class AtlasGraphSONReader {
} finally { } finally {
LOG.info("postProcess: Done! : [{}]", counter.get()); LOG.info("postProcess: Done! : [{}]", counter.get());
readerStatusManager.update(bulkLoadGraph, counter.get()); readerStatusManager.update(bulkLoadGraph, counter.get(), true);
} }
} }
...@@ -210,14 +216,14 @@ public final class AtlasGraphSONReader { ...@@ -210,14 +216,14 @@ public final class AtlasGraphSONReader {
return; return;
} }
readerStatusManager.update(graph, counter); readerStatusManager.update(graph, counter, false);
LOG.error("Thread interrupted: {}", counter); LOG.error("Thread interrupted: {}", counter);
throw new InterruptedException(); throw new InterruptedException();
} }
private void updateStatusConditionally(Graph graph, long counter) { private void updateStatusConditionally(Graph graph, long counter) {
if(counter % batchSize == 0) { if(counter % batchSize == 0) {
readerStatusManager.update(graph, counter); readerStatusManager.update(graph, counter, false);
} }
} }
......
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/JsonNodeParsers.java
...@@ -26,6 +26,7 @@ import org.slf4j.Logger; ...@@ -26,6 +26,7 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
import java.util.Map; import java.util.Map;
import java.util.NoSuchElementException;
import static org.apache.atlas.repository.Constants.EDGE_ID_IN_IMPORT_KEY; import static org.apache.atlas.repository.Constants.EDGE_ID_IN_IMPORT_KEY;
import static org.apache.atlas.repository.Constants.VERTEX_ID_IN_IMPORT_KEY; import static org.apache.atlas.repository.Constants.VERTEX_ID_IN_IMPORT_KEY;
...@@ -103,10 +104,16 @@ public class JsonNodeParsers { ...@@ -103,10 +104,16 @@ public class JsonNodeParsers {
Element getByOriginalId(Graph gr, Object id) { Element getByOriginalId(Graph gr, Object id) {
try { try {
return gr.traversal().E().has(EDGE_ID_IN_IMPORT_KEY, id).next(); return gr.traversal().E().has(EDGE_ID_IN_IMPORT_KEY, id).next();
} catch (Exception ex) { } catch (NoSuchElementException ex) {
LOG.error("fetchEdge: fetchFromDB failed: {}", id); if(LOG.isDebugEnabled()) {
return null; LOG.debug("getByOriginalId: {}: failed: {}", getMessage(), id, ex);
}
}
catch (Exception ex) {
LOG.error("getByOriginalId: {}: failed: {}", getMessage(), id, ex);
} }
return null;
} }
@Override @Override
...@@ -148,10 +155,15 @@ public class JsonNodeParsers { ...@@ -148,10 +155,15 @@ public class JsonNodeParsers {
Element getByOriginalId(Graph gr, Object id) { Element getByOriginalId(Graph gr, Object id) {
try { try {
return gr.traversal().V().has(VERTEX_ID_IN_IMPORT_KEY, id).next(); return gr.traversal().V().has(VERTEX_ID_IN_IMPORT_KEY, id).next();
} catch (NoSuchElementException ex) {
if(LOG.isDebugEnabled()) {
LOG.debug("getByOriginalId: {}: failed: {}", getMessage(), id, ex);
}
} catch (Exception ex) { } catch (Exception ex) {
LOG.error("getByOriginalId failed: {}", id); LOG.error("getByOriginalId: {}: failed: {}", getMessage(), id, ex);
return null;
} }
return null;
} }
@Override @Override
......
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/JsonNodeProcessManager.java
...@@ -187,23 +187,21 @@ public class JsonNodeProcessManager { ...@@ -187,23 +187,21 @@ public class JsonNodeProcessManager {
private final Graph bulkLoadGraph; private final Graph bulkLoadGraph;
private final ParseElement parseElement; private final ParseElement parseElement;
private final int batchSize; private final int batchSize;
private final long startIndex; private final boolean isResuming;
public ConsumerBuilder(Graph graph, Graph bulkLoadGraph, ParseElement parseElement, int batchSize, long startIndex) { public ConsumerBuilder(Graph graph, Graph bulkLoadGraph, ParseElement parseElement, int batchSize, boolean isResuming) {
this.graph = graph; this.graph = graph;
this.bulkLoadGraph = bulkLoadGraph; this.bulkLoadGraph = bulkLoadGraph;
this.batchSize = batchSize; this.batchSize = batchSize;
this.parseElement = parseElement; this.parseElement = parseElement;
this.startIndex = startIndex; this.isResuming = isResuming;
} }
@Override @Override
public Consumer build(BlockingQueue<JsonNode> queue) { public Consumer build(BlockingQueue<JsonNode> queue) {
if(startIndex == 0) { return (isResuming)
return new Consumer(queue, graph, bulkLoadGraph, parseElement, batchSize); ? new ResumingConsumer(queue, graph, bulkLoadGraph, parseElement, batchSize)
} : new Consumer(queue, graph, bulkLoadGraph, parseElement, batchSize);
return new ResumingConsumer(queue, graph, bulkLoadGraph, parseElement, batchSize);
} }
} }
...@@ -214,8 +212,8 @@ public class JsonNodeProcessManager { ...@@ -214,8 +212,8 @@ public class JsonNodeProcessManager {
} }
public static WorkItemManager create(Graph rGraph, Graph bGraph, public static WorkItemManager create(Graph rGraph, Graph bGraph,
ParseElement parseElement, int numWorkers, int batchSize, long startIndex) { ParseElement parseElement, int numWorkers, int batchSize, boolean isResuming) {
ConsumerBuilder cb = new ConsumerBuilder(rGraph, bGraph, parseElement, batchSize, startIndex); ConsumerBuilder cb = new ConsumerBuilder(rGraph, bGraph, parseElement, batchSize, isResuming);
return new WorkItemManager(cb, batchSize, numWorkers); return new WorkItemManager(cb, batchSize, numWorkers);
} }
......
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/ReaderStatusManager.java
...@@ -35,13 +35,14 @@ public class ReaderStatusManager { ...@@ -35,13 +35,14 @@ public class ReaderStatusManager {
private static final String MIGRATION_STATUS_TYPE_NAME = "__MigrationStatus"; private static final String MIGRATION_STATUS_TYPE_NAME = "__MigrationStatus";
private static final String CURRENT_INDEX_PROPERTY = "currentIndex"; private static final String CURRENT_INDEX_PROPERTY = "currentIndex";
private static final String CURRENT_COUNTER_PROPERTY = "currentCounter";
private static final String OPERATION_STATUS_PROPERTY = "operationStatus"; private static final String OPERATION_STATUS_PROPERTY = "operationStatus";
private static final String START_TIME_PROPERTY = "startTime"; private static final String START_TIME_PROPERTY = "startTime";
private static final String END_TIME_PROPERTY = "endTime"; private static final String END_TIME_PROPERTY = "endTime";
private static final String TOTAL_COUNT_PROPERTY = "totalCount"; private static final String TOTAL_COUNT_PROPERTY = "totalCount";
public static final String STATUS_NOT_STARTED = "NOT STARTED"; public static final String STATUS_NOT_STARTED = "NOT_STARTED";
public static final String STATUS_IN_PROGRESS = "IN PROGRESS"; public static final String STATUS_IN_PROGRESS = "IN_PROGRESS";
public static final String STATUS_SUCCESS = "SUCCESS"; public static final String STATUS_SUCCESS = "SUCCESS";
public static final String STATUS_FAILED = "FAILED"; public static final String STATUS_FAILED = "FAILED";
...@@ -72,8 +73,12 @@ public class ReaderStatusManager { ...@@ -72,8 +73,12 @@ public class ReaderStatusManager {
update(bGraph, counter, status); update(bGraph, counter, status);
} }
public void update(Graph graph, Long counter) { public void update(Graph graph, Long counter, boolean stageEnd) {
migrationStatus.property(CURRENT_INDEX_PROPERTY, counter); migrationStatus.property(CURRENT_COUNTER_PROPERTY, counter);
if(stageEnd) {
migrationStatus.property(CURRENT_INDEX_PROPERTY, counter);
}
if(graph.features().graph().supportsTransactions()) { if(graph.features().graph().supportsTransactions()) {
graph.tx().commit(); graph.tx().commit();
...@@ -82,7 +87,7 @@ public class ReaderStatusManager { ...@@ -82,7 +87,7 @@ public class ReaderStatusManager {
public void update(Graph graph, Long counter, String status) { public void update(Graph graph, Long counter, String status) {
migrationStatus.property(OPERATION_STATUS_PROPERTY, status); migrationStatus.property(OPERATION_STATUS_PROPERTY, status);
update(graph, counter); update(graph, counter, true);
} }
public void clear() { public void clear() {
...@@ -107,6 +112,7 @@ public class ReaderStatusManager { ...@@ -107,6 +112,7 @@ public class ReaderStatusManager {
long longValue = 0L; long longValue = 0L;
v.property(Constants.ENTITY_TYPE_PROPERTY_KEY, MIGRATION_STATUS_TYPE_NAME); v.property(Constants.ENTITY_TYPE_PROPERTY_KEY, MIGRATION_STATUS_TYPE_NAME);
v.property(CURRENT_COUNTER_PROPERTY, longValue);
v.property(CURRENT_INDEX_PROPERTY, longValue); v.property(CURRENT_INDEX_PROPERTY, longValue);
v.property(TOTAL_COUNT_PROPERTY, longValue); v.property(TOTAL_COUNT_PROPERTY, longValue);
v.property(OPERATION_STATUS_PROPERTY, STATUS_NOT_STARTED); v.property(OPERATION_STATUS_PROPERTY, STATUS_NOT_STARTED);
...@@ -122,35 +128,25 @@ public class ReaderStatusManager { ...@@ -122,35 +128,25 @@ public class ReaderStatusManager {
LOG.info("migrationStatus vertex created! v[{}]", migrationStatusId); LOG.info("migrationStatus vertex created! v[{}]", migrationStatusId);
} }
public static MigrationStatus updateFromVertex(Graph graph, MigrationStatus ms) {
Vertex vertex = fetchUsingTypeName(graph.traversal());
if(ms == null) {
ms = new MigrationStatus();
}
ms.setStartTime((Date) vertex.property(START_TIME_PROPERTY).value());
ms.setEndTime((Date) vertex.property(END_TIME_PROPERTY).value());
ms.setCurrentIndex((Long) vertex.property(CURRENT_INDEX_PROPERTY).value());
ms.setOperationStatus((String) vertex.property(OPERATION_STATUS_PROPERTY).value());
ms.setTotalCount((Long) vertex.property(TOTAL_COUNT_PROPERTY).value());
return ms;
}
public static MigrationStatus get(Graph graph) { public static MigrationStatus get(Graph graph) {
MigrationStatus ms = new MigrationStatus(); MigrationStatus ms = new MigrationStatus();
try { try {
Vertex v = fetchUsingTypeName(graph.traversal()); setValues(ms, fetchUsingTypeName(graph.traversal()));
ms.setStartTime((Date) v.property(START_TIME_PROPERTY).value());
ms.setEndTime((Date) v.property(END_TIME_PROPERTY).value());
ms.setCurrentIndex((long) v.property(CURRENT_INDEX_PROPERTY).value());
ms.setOperationStatus((String) v.property(OPERATION_STATUS_PROPERTY).value());
ms.setTotalCount((long) v.property(TOTAL_COUNT_PROPERTY).value());
} catch (Exception ex) { } catch (Exception ex) {
LOG.error("get: failed!", ex); if(LOG.isDebugEnabled()) {
LOG.error("get: failed!", ex);
}
} }
return ms; return ms;
} }
private static void setValues(MigrationStatus ms, Vertex vertex) {
ms.setStartTime((Date) vertex.property(START_TIME_PROPERTY).value());
ms.setEndTime((Date) vertex.property(END_TIME_PROPERTY).value());
ms.setCurrentIndex((Long) vertex.property(CURRENT_INDEX_PROPERTY).value());
ms.setCurrentCounter((Long) vertex.property(CURRENT_COUNTER_PROPERTY).value());
ms.setOperationStatus((String) vertex.property(OPERATION_STATUS_PROPERTY).value());
ms.setTotalCount((Long) vertex.property(TOTAL_COUNT_PROPERTY).value());
}
} }
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/ReaderStatusManagerTest.java
...@@ -34,10 +34,10 @@ public class ReaderStatusManagerTest { ...@@ -34,10 +34,10 @@ public class ReaderStatusManagerTest {
assertNotNull(tg.traversal().V(sm.migrationStatusId).next()); assertNotNull(tg.traversal().V(sm.migrationStatusId).next());
MigrationStatus ms = ReaderStatusManager.updateFromVertex(tg, null); MigrationStatus ms = ReaderStatusManager.get(tg);
assertEquals(ms.getCurrentIndex(), 0L); assertEquals(ms.getCurrentIndex(), 0L);
assertEquals(ms.getTotalCount(), 0L); assertEquals(ms.getTotalCount(), 0L);
assertEquals(ms.getOperationStatus(), "NOT STARTED"); assertEquals(ms.getOperationStatus(), ReaderStatusManager.STATUS_NOT_STARTED);
assertNotNull(ms.getStartTime()); assertNotNull(ms.getStartTime());
assertNotNull(ms.getEndTime()); assertNotNull(ms.getEndTime());
} }
...@@ -45,15 +45,15 @@ public class ReaderStatusManagerTest { ...@@ -45,15 +45,15 @@ public class ReaderStatusManagerTest {
@Test @Test
public void verifyUpdates() { public void verifyUpdates() {
long expectedTotalCount = 1001L; long expectedTotalCount = 1001L;
String expectedOperationStatus = "SUCCESS"; String expectedOperationStatus = ReaderStatusManager.STATUS_SUCCESS;
TinkerGraph tg = TinkerGraph.open(); TinkerGraph tg = TinkerGraph.open();
ReaderStatusManager sm = new ReaderStatusManager(tg, tg); ReaderStatusManager sm = new ReaderStatusManager(tg, tg);
sm.update(tg, 1000L, "IN PROGRESS"); sm.update(tg, 1000L, ReaderStatusManager.STATUS_IN_PROGRESS);
sm.end(tg, expectedTotalCount, expectedOperationStatus); sm.end(tg, expectedTotalCount, expectedOperationStatus);
MigrationStatus ms = ReaderStatusManager.updateFromVertex(tg, null); MigrationStatus ms = ReaderStatusManager.get(tg);
assertEquals(ms.getCurrentIndex(), expectedTotalCount); assertEquals(ms.getCurrentIndex(), expectedTotalCount);
assertEquals(ms.getTotalCount(), expectedTotalCount); assertEquals(ms.getTotalCount(), expectedTotalCount);
assertEquals(ms.getOperationStatus(), expectedOperationStatus); assertEquals(ms.getOperationStatus(), expectedOperationStatus);
......
intg/src/main/java/org/apache/atlas/model/impexp/MigrationStatus.java
...@@ -38,6 +38,7 @@ public class MigrationStatus implements Serializable { ...@@ -38,6 +38,7 @@ public class MigrationStatus implements Serializable {
private Date startTime; private Date startTime;
private Date endTime; private Date endTime;
private long currentIndex; private long currentIndex;
private long currentCounter;
private long totalCount; private long totalCount;
public void setOperationStatus(String operationStatus) { public void setOperationStatus(String operationStatus) {
...@@ -80,11 +81,18 @@ public class MigrationStatus implements Serializable { ...@@ -80,11 +81,18 @@ public class MigrationStatus implements Serializable {
return this.totalCount; return this.totalCount;
} }
public StringBuilder toString(StringBuilder sb) { public void setCurrentCounter(long value) {
this.currentCounter = value;
}
public Long getCurrentCounter() { return this.currentCounter; }
public StringBuilder toString(StringBuilder sb) {
sb.append(", operationStatus=").append(operationStatus); sb.append(", operationStatus=").append(operationStatus);
sb.append(", startTime=").append(startTime); sb.append(", startTime=").append(startTime);
sb.append(", endTime=").append(endTime); sb.append(", endTime=").append(endTime);
sb.append(", currentIndex=").append(currentIndex); sb.append(", currentIndex=").append(currentIndex);
sb.append(", currentCounter=").append(currentCounter);
sb.append(", totalCount=").append(totalCount); sb.append(", totalCount=").append(totalCount);
return sb; return sb;
......
repository/src/main/java/org/apache/atlas/repository/migration/DataMigrationService.java
...@@ -32,6 +32,7 @@ import org.apache.commons.configuration.Configuration; ...@@ -32,6 +32,7 @@ import org.apache.commons.configuration.Configuration;
import org.apache.atlas.AtlasException; import org.apache.atlas.AtlasException;
import org.apache.atlas.service.Service; import org.apache.atlas.service.Service;
import org.apache.commons.io.FileUtils; import org.apache.commons.io.FileUtils;
import org.apache.solr.common.StringUtils;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
import org.springframework.stereotype.Component; import org.springframework.stereotype.Component;
...@@ -100,6 +101,10 @@ public class DataMigrationService implements Service { ...@@ -100,6 +101,10 @@ public class DataMigrationService implements Service {
public void performImport() throws AtlasBaseException { public void performImport() throws AtlasBaseException {
try { try {
if(!performAccessChecks(importDirectory)) {
return;
}
performInit(); performInit();
FileInputStream fs = new FileInputStream(getFileFromImportDirectory(importDirectory, ATLAS_MIGRATION_DATA_NAME)); FileInputStream fs = new FileInputStream(getFileFromImportDirectory(importDirectory, ATLAS_MIGRATION_DATA_NAME));
...@@ -111,10 +116,28 @@ public class DataMigrationService implements Service { ...@@ -111,10 +116,28 @@ public class DataMigrationService implements Service {
} }
} }
private boolean performAccessChecks(String path) {
boolean ret = false;
if(StringUtils.isEmpty(path)) {
ret = false;
} else {
File f = new File(path);
ret = f.exists() && f.isDirectory() && f.canRead();
}
if (ret) {
LOG.info("will migrate data in directory {}", importDirectory);
} else {
LOG.error("cannot read migration data in directory {}", importDirectory);
}
return ret;
}
private void performInit() throws AtlasBaseException, AtlasException { private void performInit() throws AtlasBaseException, AtlasException {
storeInitializer.init();
processIncomingTypesDef(getFileFromImportDirectory(importDirectory, ATLAS_MIGRATION_TYPESDEF_NAME));
indexer.instanceIsActive(); indexer.instanceIsActive();
storeInitializer.instanceIsActive();
processIncomingTypesDef(getFileFromImportDirectory(importDirectory, ATLAS_MIGRATION_TYPESDEF_NAME));
} }
@VisibleForTesting @VisibleForTesting
......
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
...@@ -64,8 +64,6 @@ import java.util.Map; ...@@ -64,8 +64,6 @@ import java.util.Map;
import static com.fasterxml.jackson.annotation.JsonAutoDetect.Visibility.NONE; import static com.fasterxml.jackson.annotation.JsonAutoDetect.Visibility.NONE;
import static com.fasterxml.jackson.annotation.JsonAutoDetect.Visibility.PUBLIC_ONLY; import static com.fasterxml.jackson.annotation.JsonAutoDetect.Visibility.PUBLIC_ONLY;
import static org.apache.atlas.AtlasConstants.ATLAS_MIGRATION_MODE_FILENAME;
/** /**
* Class that handles initial loading of models and patches into typedef store * Class that handles initial loading of models and patches into typedef store
...@@ -90,9 +88,8 @@ public class AtlasTypeDefStoreInitializer implements ActiveStateChangeHandler { ...@@ -90,9 +88,8 @@ public class AtlasTypeDefStoreInitializer implements ActiveStateChangeHandler {
@PostConstruct @PostConstruct
public void init() throws AtlasBaseException { public void init() throws AtlasBaseException {
LOG.info("==> AtlasTypeDefStoreInitializer.init()"); LOG.info("==> AtlasTypeDefStoreInitializer.init()");
boolean isMigrationEnabled = !StringUtils.isEmpty(conf.getString(ATLAS_MIGRATION_MODE_FILENAME));
if (!HAConfiguration.isHAEnabled(conf) || isMigrationEnabled) { if (!HAConfiguration.isHAEnabled(conf)) {
atlasTypeDefStore.init(); atlasTypeDefStore.init();
loadBootstrapTypeDefs(); loadBootstrapTypeDefs();
......
repository/src/test/java/org/apache/atlas/repository/migration/HiveParititionTest.java
...@@ -43,7 +43,7 @@ public class HiveParititionTest extends MigrationBaseAsserts { ...@@ -43,7 +43,7 @@ public class HiveParititionTest extends MigrationBaseAsserts {
@Test @Test
public void fileImporterTest() throws IOException, AtlasBaseException { public void fileImporterTest() throws IOException, AtlasBaseException {
final int EXPECTED_TOTAL_COUNT = 140; final int EXPECTED_TOTAL_COUNT = 141;
final int EXPECTED_DB_COUNT = 1; final int EXPECTED_DB_COUNT = 1;
final int EXPECTED_TABLE_COUNT = 2; final int EXPECTED_TABLE_COUNT = 2;
final int EXPECTED_COLUMN_COUNT = 7; final int EXPECTED_COLUMN_COUNT = 7;
......
repository/src/test/java/org/apache/atlas/repository/migration/HiveStocksTest.java
...@@ -37,7 +37,7 @@ public class HiveStocksTest extends MigrationBaseAsserts { ...@@ -37,7 +37,7 @@ public class HiveStocksTest extends MigrationBaseAsserts {
@Test @Test
public void migrateStocks() throws AtlasBaseException, IOException { public void migrateStocks() throws AtlasBaseException, IOException {
final int EXPECTED_TOTAL_COUNT = 187; final int EXPECTED_TOTAL_COUNT = 188;
final int EXPECTED_DB_COUNT = 1; final int EXPECTED_DB_COUNT = 1;
final int EXPECTED_TABLE_COUNT = 1; final int EXPECTED_TABLE_COUNT = 1;
final int EXPECTED_COLUMN_COUNT = 7; final int EXPECTED_COLUMN_COUNT = 7;
......
repository/src/test/java/org/apache/atlas/repository/migration/MigrationProgressServiceTest.java
...@@ -127,7 +127,7 @@ public class MigrationProgressServiceTest { ...@@ -127,7 +127,7 @@ public class MigrationProgressServiceTest {
} }
ReaderStatusManager rsm = new ReaderStatusManager(tg, tg); ReaderStatusManager rsm = new ReaderStatusManager(tg, tg);
rsm.update(tg, currentIndex); rsm.update(tg, currentIndex, false);
rsm.end(tg, totalIndex, status); rsm.end(tg, totalIndex, status);
return tg; return tg;
} }
......
repository/src/test/java/org/apache/atlas/repository/migration/PathTest.java
...@@ -44,11 +44,13 @@ public class PathTest extends MigrationBaseAsserts { ...@@ -44,11 +44,13 @@ public class PathTest extends MigrationBaseAsserts {
@Test @Test
public void migrationImport() throws IOException, AtlasBaseException { public void migrationImport() throws IOException, AtlasBaseException {
final int EXPECTED_TOTAL_COUNT = 89;
runFileImporter("path_db"); runFileImporter("path_db");
AtlasVertex v = assertHdfsPathVertices(1); AtlasVertex v = assertHdfsPathVertices(1);
assertVertexProperties(v); assertVertexProperties(v);
assertMigrationStatus(88); assertMigrationStatus(EXPECTED_TOTAL_COUNT);
} }
private void assertVertexProperties(AtlasVertex v) { private void assertVertexProperties(AtlasVertex v) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment