ATLAS-318 Config file conatining API endpoint + all api calls to be centralized…

dashboard/.jshintrc

@@ -40,7 +40,8 @@
     "unused": true, // Warn unused variables.
     "globals": { // Globals variables.
         "angular": true,
-        "$": false
+        "$": false,
+        "baseUrl":true
     },
     "predef": [ // Extra globals.
         "define",

dashboard/gruntfile.js

@@ -95,6 +95,7 @@ module.exports = function(grunt) {
         dist: distPath + '/js/app.min.js',
         modules: grunt.file.expand(
             modulesPath + 'js/app.js',
+            modulesPath + 'js/config.js',
             modulesPath + 'js/routes.js',
             modulesPath + 'modules/**/*Module.js',
             modulesPath + 'modules/**/*.js',

dashboard/public/js/app.js

@@ -51,8 +51,8 @@ angular.module('dgc').factory('lodash', ['$window',
     }
 ]).factory('HttpInterceptor', ['Global', function(Global) {
     return {
-        'request': function(config) {
-            if (config.url && (config.url.indexOf('api/atlas/') === 0 || config.url.indexOf('/api/atlas/') === 0)) {
+        'request': function(config) { 
+            if (config.url && (config.url.indexOf(baseUrl) === 0 || config.url.indexOf(baseUrl) === 0)) {
                 config.params = config.params || {};
                 config.params['user.name'] = Global.user;
             }

dashboard/public/js/config.js

+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+'use strict';
+var host = '',
+    port = '',
+    baseUrl = '/api/atlas/',
+    apiHost = (host!=='') ? host + ':' + port + baseUrl : baseUrl ;
+
+angular.module('dgc').constant('AtlasConfig', { 
+    API_ENDPOINTS: {
+        ABOUT: apiHost + 'admin/version',
+        GET_ENTITY: apiHost + 'entities',
+        ATTACH_DETACH_TRAITS:   'traits',
+        SCHEMA_LINEAGE_PREPEND: apiHost + 'lineage/hive/table',
+        SCHEMA_APPEND: 'schema',
+        GRAPH:  'graph',
+        TRAITS_LIST: apiHost + 'types?type=TRAIT',
+        SEARCH: apiHost + 'discovery/search/',
+        CREATE_TRAIT: apiHost + 'types'
+    }
+});
\ No newline at end of file

dashboard/public/modules/about/aboutResource.js

@@ -18,6 +18,6 @@
 
 'use strict';
 
-angular.module('dgc.about').factory('AboutResource', ['$resource', function($resource) {
-    return $resource('/api/atlas/admin/version', {});
+angular.module('dgc.about').factory('AboutResource', ['$resource', 'AtlasConfig', function($resource, AtlasConfig) {
+    return $resource(AtlasConfig.API_ENDPOINTS.ABOUT, {});
 }]);

dashboard/public/modules/details/detailsResource.js

@@ -18,8 +18,8 @@
 
 'use strict';
 
-angular.module('dgc.details').factory('DetailsResource', ['$resource', function($resource) {
-    return $resource('/api/atlas/entities/:id', {}, {
+angular.module('dgc.details').factory('DetailsResource', ['$resource', 'AtlasConfig', function($resource, AtlasConfig) {
+    return $resource(AtlasConfig.API_ENDPOINTS.GET_ENTITY +'/:id', {}, {
         get: {
             method: 'GET',
             transformResponse: function(data) {
@@ -31,16 +31,16 @@ angular.module('dgc.details').factory('DetailsResource', ['$resource', function(
         },
         saveTag: {
             method: 'POST',
-            url: '/api/atlas/entities/:id/traits'
+            url : AtlasConfig.API_ENDPOINTS.GET_ENTITY + '/:id/' + AtlasConfig.API_ENDPOINTS.ATTACH_DETACH_TRAITS
         },
         detachTag : {
             method: 'DELETE',
-            url: '/api/atlas/entities/:id/traits/:tagName'
+            url : AtlasConfig.API_ENDPOINTS.GET_ENTITY + '/:id/' + AtlasConfig.API_ENDPOINTS.ATTACH_DETACH_TRAITS + '/:tagName'
         }
      });
 
-}]).factory('SchemaResource', ['$resource', function($resource) {
-    return $resource('/api/atlas/lineage/hive/table/:tableName/schema', {}, {
+}]).factory('SchemaResource', ['$resource','AtlasConfig', function($resource, AtlasConfig) {
+    return $resource(AtlasConfig.API_ENDPOINTS.SCHEMA_LINEAGE_PREPEND + '/:tableName/' + AtlasConfig.API_ENDPOINTS.SCHEMA_APPEND, {}, {
         get: {
             method: 'GET',
             transformResponse: function(data) {

dashboard/public/modules/lineage/lineageResource.js

@@ -18,6 +18,6 @@
 
 'use strict';
 
-angular.module('dgc.lineage').factory('LineageResource', ['$resource', function($resource) {
-    return $resource('/api/atlas/lineage/hive/table/:tableName/:type/graph', {});
+angular.module('dgc.lineage').factory('LineageResource', ['$resource','AtlasConfig', function($resource, AtlasConfig) {
+    return $resource(AtlasConfig.API_ENDPOINTS.SCHEMA_LINEAGE_PREPEND+'/:tableName/:type/'+AtlasConfig.API_ENDPOINTS.GRAPH, {});
 }]);

dashboard/public/modules/navigation/navigationController.js

@@ -17,8 +17,8 @@
  */
 'use strict';
 
-angular.module('dgc.navigation').controller('NavigationController', ['$scope', 'NavigationResource', '$cacheFactory',
-    function($scope, NavigationResource, $cacheFactory) {
+angular.module('dgc.navigation').controller('NavigationController', ['$scope', 'NavigationResource', '$cacheFactory','AtlasConfig',
+    function($scope, NavigationResource, $cacheFactory,AtlasConfig) {
 
         $scope.updateVar = function(event) {
             $scope.$$prevSibling.query = angular.element(event.target).text();
@@ -31,12 +31,12 @@ angular.module('dgc.navigation').controller('NavigationController', ['$scope', '
 
         setTimeout(function() {
          	var httpDefaultCache = $cacheFactory.get('$http');
-            httpDefaultCache.remove('/api/atlas/types?type=TRAIT');
+            httpDefaultCache.remove(AtlasConfig.API_ENDPOINTS.TRAITS_LIST);
         }, 3600000);
 
         $scope.refreshTags = function(){
         	var httpDefaultCache = $cacheFactory.get('$http');
-        	httpDefaultCache.remove('/api/atlas/types?type=TRAIT');
+        	httpDefaultCache.remove(AtlasConfig.API_ENDPOINTS.TRAITS_LIST);
         	$scope.leftnav = NavigationResource.get();
         }; 
 

dashboard/public/modules/navigation/navigationResource.js

@@ -18,8 +18,8 @@
 
 'use strict';
 
-angular.module('dgc.navigation').factory('NavigationResource', ['$resource', function($resource) {
-    return $resource('/api/atlas/types?type=TRAIT', {}, {
+angular.module('dgc.navigation').factory('NavigationResource', ['$resource','AtlasConfig', function($resource, AtlasConfig) {
+    return $resource(AtlasConfig.API_ENDPOINTS.TRAITS_LIST, {}, {
         get: {
             'method': 'GET',
             'responseType': 'json',

dashboard/public/modules/search/searchResource.js

@@ -18,8 +18,8 @@
 
 'use strict';
 
-angular.module('dgc.search').factory('SearchResource', ['$resource', function($resource) {
-    return $resource('/api/atlas/discovery/search/', {}, {
+angular.module('dgc.search').factory('SearchResource', ['$resource', 'AtlasConfig', function($resource, AtlasConfig) {
+    return $resource(AtlasConfig.API_ENDPOINTS.SEARCH, {}, {
         search: {
             'method': 'GET',
             'responseType': 'json',

dashboard/public/modules/tags/definition/definitionTagsController.js

@@ -17,8 +17,8 @@
  */
 'use strict';
 
-angular.module('dgc.tags.definition').controller('DefinitionTagsController', ['$scope', '$resource', '$state', '$stateParams', 'lodash', 'AttributeDefinition', 'TagClasses', 'TagsResource', 'NotificationService', 'NavigationResource', '$cacheFactory',
-    function($scope, $resource, $state, $stateParams, _, AttributeDefinition, Categories, TagsResource, NotificationService, NavigationResource, $cacheFactory) {
+angular.module('dgc.tags.definition').controller('DefinitionTagsController', ['$scope', '$resource', '$state', '$stateParams', 'lodash', 'AttributeDefinition', 'TagClasses', 'TagsResource', 'NotificationService', 'NavigationResource', '$cacheFactory','AtlasConfig',
+    function($scope, $resource, $state, $stateParams, _, AttributeDefinition, Categories, TagsResource, NotificationService, NavigationResource, $cacheFactory,AtlasConfig) {
         $scope.categoryList = Categories;
         $scope.category = 'TRAIT';
         $scope.tagModel = {
@@ -47,7 +47,7 @@ angular.module('dgc.tags.definition').controller('DefinitionTagsController', ['$
 
         $scope.refreshTags = function(){
             var httpDefaultCache = $cacheFactory.get('$http');
-            httpDefaultCache.remove('/api/atlas/types?type=TRAIT');
+            httpDefaultCache.remove(AtlasConfig.API_ENDPOINTS.TRAITS_LIST);
             $scope.typesList = NavigationResource.get();
         }; 
 
@@ -65,7 +65,7 @@ angular.module('dgc.tags.definition').controller('DefinitionTagsController', ['$
                     .then(function TagCreateSuccess() {
                         NotificationService.info('"' + $scope.tagModel.typeName + '" has been created', false);
                         var httpDefaultCache = $cacheFactory.get('$http');
-                        httpDefaultCache.remove('/api/atlas/types?type=TRAIT');
+                        httpDefaultCache.remove(AtlasConfig.API_ENDPOINTS.TRAITS_LIST);
                         $scope.typesList = NavigationResource.get();
                         $scope.reset();
                     }).catch(function TagCreateFailed(error) {

dashboard/public/modules/tags/tagsResource.js

@@ -18,8 +18,8 @@
 
 'use strict';
 
-angular.module('dgc.tags').factory('TagsResource', ['$resource', function($resource) {
-    return $resource('/api/atlas/types/:id', {}, {
+angular.module('dgc.tags').factory('TagsResource', ['$resource', 'AtlasConfig', function($resource, AtlasConfig) {
+    return $resource(AtlasConfig.API_ENDPOINTS.CREATE_TRAIT + '/:id', {}, {
         query: {
             method: 'GET',
             transformResponse: function(data) {