Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
A
atlas
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
dataplatform
atlas
Commits
ce2ba123
Commit
ce2ba123
authored
4 years ago
by
kevalbhatt
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ATLAS-3904: Regression: Glossary term deatils page not able to render the classfication tab #2
parent
38d7b91e
master
No related merge requests found
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
22 additions
and
8 deletions
+22
-8
DetailPageLayoutView.js
...ardv2/public/js/views/detail_page/DetailPageLayoutView.js
+11
-4
DetailPageLayoutView.js
...ardv3/public/js/views/detail_page/DetailPageLayoutView.js
+11
-4
No files found.
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js
View file @
ce2ba123
...
...
@@ -381,19 +381,26 @@ define(['require',
this
.
$
(
'.fontLoader-relative'
).
addClass
(
'show'
);
// to show tab loader
},
manualRender
:
function
(
options
)
{
if
(
this
.
id
!==
options
.
id
)
{
if
(
options
)
{
var
oldId
=
this
.
id
;
_
.
extend
(
this
,
_
.
pick
(
options
,
'value'
,
'id'
));
this
.
collection
.
url
=
UrlLinks
.
entitiesApiUrl
({
guid
:
this
.
id
,
minExtInfo
:
true
});
this
.
fetchCollection
();
if
(
this
.
id
!==
oldId
)
{
this
.
collection
.
url
=
UrlLinks
.
entitiesApiUrl
({
guid
:
this
.
id
,
minExtInfo
:
true
});
this
.
fetchCollection
();
}
this
.
updateTab
();
}
},
onShow
:
function
()
{
updateTab
:
function
()
{
if
(
this
.
value
&&
this
.
value
.
tabActive
)
{
this
.
$
(
'.nav.nav-tabs'
).
find
(
'[role="'
+
this
.
value
.
tabActive
+
'"]'
).
addClass
(
'active'
).
siblings
().
removeClass
(
'active'
);
this
.
$
(
'.tab-content'
).
find
(
'[role="'
+
this
.
value
.
tabActive
+
'"]'
).
addClass
(
'active'
).
siblings
().
removeClass
(
'active'
);
$
(
"html, body"
).
animate
({
scrollTop
:
(
this
.
$
(
'.tab-content'
).
offset
().
top
+
1200
)
},
1000
);
}
},
onShow
:
function
()
{
this
.
updateTab
();
},
onDestroy
:
function
()
{
if
(
!
Utils
.
getUrlState
.
isDetailPage
())
{
$
(
'body'
).
removeClass
(
"detail-page"
);
...
...
This diff is collapsed.
Click to expand it.
dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js
View file @
ce2ba123
...
...
@@ -385,19 +385,26 @@ define(['require',
this
.
$
(
'.fontLoader-relative'
).
addClass
(
'show'
);
// to show tab loader
},
manualRender
:
function
(
options
)
{
if
(
this
.
id
!==
options
.
id
)
{
if
(
options
)
{
var
oldId
=
this
.
id
;
_
.
extend
(
this
,
_
.
pick
(
options
,
'value'
,
'id'
));
this
.
collection
.
url
=
UrlLinks
.
entitiesApiUrl
({
guid
:
this
.
id
,
minExtInfo
:
true
});
this
.
fetchCollection
();
if
(
this
.
id
!==
oldId
)
{
this
.
collection
.
url
=
UrlLinks
.
entitiesApiUrl
({
guid
:
this
.
id
,
minExtInfo
:
true
});
this
.
fetchCollection
();
}
this
.
updateTab
();
}
},
onShow
:
function
()
{
updateTab
:
function
()
{
if
(
this
.
value
&&
this
.
value
.
tabActive
)
{
this
.
$
(
'.nav.nav-tabs'
).
find
(
'[role="'
+
this
.
value
.
tabActive
+
'"]'
).
addClass
(
'active'
).
siblings
().
removeClass
(
'active'
);
this
.
$
(
'.tab-content'
).
find
(
'[role="'
+
this
.
value
.
tabActive
+
'"]'
).
addClass
(
'active'
).
siblings
().
removeClass
(
'active'
);
$
(
"html, body"
).
animate
({
scrollTop
:
(
this
.
$
(
'.tab-content'
).
offset
().
top
+
1200
)
},
1000
);
}
},
onShow
:
function
()
{
this
.
updateTab
();
},
onDestroy
:
function
()
{
if
(
!
Utils
.
getUrlState
.
isDetailPage
())
{
$
(
'body'
).
removeClass
(
"detail-page"
);
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment