BUG-37674 quick start is broken post rest api refactoring

client/src/main/java/org/apache/hadoop/metadata/PropertiesUtil.java

@@ -18,13 +18,11 @@
 
 package org.apache.hadoop.metadata;
 
-import org.apache.commons.configuration.ConfigurationException;
 import org.apache.commons.configuration.PropertiesConfiguration;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import java.io.File;
-import java.net.MalformedURLException;
 import java.net.URL;
 
 public class PropertiesUtil {
@@ -33,11 +31,11 @@ public class PropertiesUtil {
     private static final String APPLICATION_PROPERTIES = "application.properties";
     public static final String CLIENT_PROPERTIES = "client.properties";
 
-    public static final PropertiesConfiguration getApplicationProperties() throws MetadataException {
+    public static PropertiesConfiguration getApplicationProperties() throws MetadataException {
         return getPropertiesConfiguration(APPLICATION_PROPERTIES);
     }
 
-    public static final PropertiesConfiguration getClientProperties() throws MetadataException {
+    public static PropertiesConfiguration getClientProperties() throws MetadataException {
         return getPropertiesConfiguration(CLIENT_PROPERTIES);
     }
 

src/conf/application.properties

@@ -30,9 +30,9 @@ metadata.graph.index.search.elasticsearch.create.sleep=2000
 
 #########  Hive Lineage Configs  #########
 # This models follows the quick-start guide
-metadata.lineage.hive.table.type.name=hive_table
+metadata.lineage.hive.table.type.name=Table
 metadata.lineage.hive.table.column.name=columns
-metadata.lineage.hive.process.type.name=hive_process
+metadata.lineage.hive.process.type.name=LoadProcess
 metadata.lineage.hive.process.inputs.name=inputTables
 metadata.lineage.hive.process.outputs.name=outputTables
 #Currently unused

webapp/src/main/java/org/apache/hadoop/metadata/examples/QuickStart.java

@@ -300,7 +300,7 @@ public class QuickStart {
         String entityJSON = InstanceSerialization.toJson(referenceable, true);
         System.out.println("Submitting new entity= " + entityJSON);
         JSONObject jsonObject = metadataServiceClient.createEntity(entityJSON);
-        String guid = jsonObject.getString(MetadataServiceClient.RESULTS);
+        String guid = jsonObject.getString(MetadataServiceClient.GUID);
         System.out.println("created instance for type " + typeName + ", guid: " + guid);
 
         // return the Id for created instance with guid

webapp/src/main/java/org/apache/hadoop/metadata/web/resources/MetadataDiscoveryResource.java

@@ -82,7 +82,7 @@ public class MetadataDiscoveryResource {
             return searchUsingGremlinQuery(query);
         }
 
-        JSONObject response = null;
+        JSONObject response;
 
         try {   // fall back to dsl
             final String jsonResultStr = discoveryService.searchByDSL(query);

webapp/src/main/java/org/apache/hadoop/metadata/web/resources/TypesResource.java

@@ -18,15 +18,11 @@
 
 package org.apache.hadoop.metadata.web.resources;
 
-import com.google.common.base.Preconditions;
-import com.google.inject.Guice;
 import com.sun.jersey.api.client.ClientResponse;
 import org.apache.hadoop.metadata.MetadataException;
 import org.apache.hadoop.metadata.MetadataServiceClient;
 import org.apache.hadoop.metadata.services.MetadataService;
 import org.apache.hadoop.metadata.typesystem.types.DataTypes;
-import org.apache.hadoop.metadata.typesystem.types.IDataType;
-import org.apache.hadoop.metadata.web.listeners.GuiceServletConfig;
 import org.apache.hadoop.metadata.web.util.Servlets;
 import org.codehaus.jettison.json.JSONArray;
 import org.codehaus.jettison.json.JSONException;
@@ -37,9 +33,18 @@ import org.slf4j.LoggerFactory;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 import javax.servlet.http.HttpServletRequest;
-import javax.ws.rs.*;
-import javax.ws.rs.core.*;
-import java.net.URI;
+import javax.ws.rs.Consumes;
+import javax.ws.rs.DefaultValue;
+import javax.ws.rs.GET;
+import javax.ws.rs.POST;
+import javax.ws.rs.Path;
+import javax.ws.rs.PathParam;
+import javax.ws.rs.Produces;
+import javax.ws.rs.QueryParam;
+import javax.ws.rs.WebApplicationException;
+import javax.ws.rs.core.Context;
+import javax.ws.rs.core.MediaType;
+import javax.ws.rs.core.Response;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
@@ -141,7 +146,7 @@ public class TypesResource {
     public Response getTypesByFilter(@Context HttpServletRequest request,
                                      @DefaultValue(TYPE_ALL) @QueryParam("type") String type) {
         try {
-            List<String> result = null;
+            List<String> result;
             if (TYPE_ALL.equals(type)) {
                 result = metadataService.getTypeNamesList();
             } else {

webapp/src/main/resources/application.properties

@@ -29,7 +29,6 @@ metadata.graph.index.search.elasticsearch.local-mode=true
 metadata.graph.index.search.elasticsearch.create.sleep=2000
 
 #########  Hive Lineage Configs  #########
-# This models follows the quick-start guide
 metadata.lineage.hive.table.type.name=hive_table
 metadata.lineage.hive.column.type.name=hive_column
 metadata.lineage.hive.table.column.name=columns